Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid R CMD check warning regarding SETLENGTH() and SET_TRUELENGTH() #145

Merged
merged 6 commits into from
Apr 27, 2024

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Apr 26, 2024

Timings for running all tests didn't change too much. Need more investigation if this actually harms performance, will await user reports.

This PR

R -q -e 'testthat::test_local()' 12.58s user 1.87s system 95% cpu 15.192 total

Parent

R -q -e 'testthat::test_local()' 13.12s user 1.99s system 96% cpu 15.644 total

@krlmlr krlmlr merged commit 0618f9f into main Apr 27, 2024
22 of 23 checks passed
@krlmlr krlmlr deleted the b-setlength branch April 27, 2024 18:28
@chainsawriot chainsawriot mentioned this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant